Move some tests to more reasonable directories - 4 #81941

c410-f3r · 2021-02-09T23:16:35Z

issues/issue-4201.rs ^issue: expr 1.000
old-suffixes-are-really-forbidden.rs ^unknown: parser 1.031
typeclasses-eq-example-static.rs ^unknown: binding 1.033
issues/issue-33537.rs ^issue: consts 1.036
issues/issue-31924-non-snake-ffi.rs ^issue: lint 1.046
issues/issue-44406.rs ^issue: parser 1.051
type-id-higher-rank.rs ^unknown: unboxed-closures 1.074
issues/issue-20616-3.rs ^issue: parser 1.077
html-literals.rs ^unknown: macros 1.083
issues/issue-13837.rs ^issue: consts 1.089
issues/issue-21726.rs ^issue: associated-types 1.095
one-tuple.rs ^unknown: binding 1.107
issues/issue-43784-associated-type.rs ^issue: associated-types 1.108
project-defer-unification.rs ^unknown: associated-types 1.109
struct-literal-variant-in-if.rs ^unknown: parser 1.110
rvalue-static-promotion.rs ^unknown: consts 1.114
nullable-pointer-ffi-compat.rs ^unknown: regions 1.129
range_inclusive_gate.rs ^unknown: for-loop-while 1.174
simd-type-generic-monomorphisation.rs ^unknown: simd 1.175
issues/issue-77993-2.rs ^issue: async-await 1.183
issues/issue-23595-2.rs ^issue: associated-types 1.194
issues/issue-40847.rs ^issue: macros 1.194
issues/issue-6157.rs ^issue: regions 1.195
issues/issue-32829.rs ^issue: consts 1.241
type-sizes.rs ^unknown: structs-enums 1.281
issues/issue-24204.rs ^issue: associated-types 1.305
issues/issue-22560.rs ^issue: associated-types 1.354
emit-artifact-notifications.rs ^unknown: rmeta 1.368
repeat_count_const_in_async_fn.rs ^unknown: async-await 1.370
expr-if-panic.rs ^unknown: expr 1.371
cleanup-rvalue-during-if-and-while.rs ^unknown: for-loop-while 1.378
write-to-static-mut-in-static.rs ^unknown: consts 1.381
issues/issue-17718-references.rs ^issue: consts 1.404
dotdotdot-expr.rs ^unknown: parser 1.784
regions-fn-subtyping-return-static-fail.rs ^unknown: regions 1.959

petrochenkov · 2021-02-13T15:09:58Z

Misclassified tests, better moved elsewhere:
one-tuple.rs -> src/test/ui/tuple/one-tuple.rs
expr-if-panic.rs -> src/test/ui/expr/if/expr-if-panic.rs
issue-4201.rs -> src/test/ui/expr/if/issue-4201.rs
issue-40847.rs -> src/test/ui/hygiene/issue-40847.rs

Misclassified tests, not clear where to move, let's keep in issues for now:
typeclasses-eq-example-static.rs
nullable-pointer-ffi-compat.rs
issue-6157.rs

Tests that can be removed:
range_inclusive_gate.rs

Also, tidy needs to be updated and commits squashed.

c410-f3r · 2021-02-14T17:50:07Z

@petrochenkov Done

petrochenkov · 2021-02-15T00:06:16Z

@bors r+

bors · 2021-02-15T00:06:17Z

📌 Commit 34f30bc has been approved by petrochenkov

JohnTitor · 2021-02-15T07:50:17Z

Failed in rollup: #82138 (comment)
@bors r-

petrochenkov · 2021-02-15T20:33:34Z

@bors r+

bors · 2021-02-15T20:33:35Z

📌 Commit c914952 has been approved by petrochenkov

Dylan-DPC-zz · 2021-02-17T00:10:14Z

failed in rollup

@bors r-

c410-f3r · 2021-02-17T00:21:13Z

2021-02-16T23:41:41.3485228Z tidy error: following path contains more than 2576 entries, you should move the test to some relevant subdirectory (current: 2577): /checkout/src/test/ui/issues

2576 contained a surplus to avoid this type of error but is already outdated. Crazy

c410-f3r · 2021-02-17T00:24:12Z

Threshold was updated.
@Dylan-DPC Can you re-open?

JohnTitor · 2021-02-17T00:38:54Z

Seems we cannot re-open since you force-pushed to the branch. Could you recreate a new one?

Dylan-DPC-zz · 2021-02-17T00:41:58Z

oops closed the wrong pr, sorry about that

c410-f3r · 2021-02-17T00:45:25Z

Thanks! Just opened #82203

…-DPC Move some tests to more reasonable directories - 4 cc rust-lang#81941

rust-highfive assigned petrochenkov Feb 9, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 9, 2021

This comment has been minimized.

Sign in to view

c410-f3r force-pushed the tests-tests-tests branch from 5f31d3c to ca4c94f Compare February 11, 2021 01:44

This comment has been minimized.

Sign in to view

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2021

This comment has been minimized.

Sign in to view

c410-f3r force-pushed the tests-tests-tests branch from 012523a to 2c918cc Compare February 14, 2021 13:58

c410-f3r force-pushed the tests-tests-tests branch 2 times, most recently from e10ad59 to 34f30bc Compare February 14, 2021 17:53

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 15, 2021

JohnTitor mentioned this pull request Feb 15, 2021

Rollup of 13 pull requests #82138

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2021

Move some tests to more reasonable directories

c914952

c410-f3r force-pushed the tests-tests-tests branch from 34f30bc to c914952 Compare February 15, 2021 12:56

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 15, 2021

Dylan-DPC-zz mentioned this pull request Feb 16, 2021

Rollup of 13 pull requests #82186

Closed

Dylan-DPC-zz mentioned this pull request Feb 16, 2021

Rollup of 11 pull requests #82200

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 17, 2021

Dylan-DPC-zz closed this Feb 17, 2021

c410-f3r mentioned this pull request Feb 17, 2021

Move some tests to more reasonable directories - 4 #82203

Merged

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 18, 2021

Rollup merge of rust-lang#82203 - c410-f3r:tests-tests-tests, r=Dylan…

fe15494

…-DPC Move some tests to more reasonable directories - 4 cc rust-lang#81941

c410-f3r mentioned this pull request Apr 17, 2022

Move some tests to more reasonable places #96144

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move some tests to more reasonable directories - 4 #81941

Move some tests to more reasonable directories - 4 #81941

Uh oh!

c410-f3r commented Feb 9, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Feb 13, 2021

Uh oh!

This comment has been minimized.

c410-f3r commented Feb 14, 2021

Uh oh!

petrochenkov commented Feb 15, 2021

Uh oh!

bors commented Feb 15, 2021

Uh oh!

JohnTitor commented Feb 15, 2021

Uh oh!

petrochenkov commented Feb 15, 2021

Uh oh!

bors commented Feb 15, 2021

Uh oh!

Dylan-DPC-zz commented Feb 17, 2021

Uh oh!

c410-f3r commented Feb 17, 2021 •

edited

Loading

Uh oh!

c410-f3r commented Feb 17, 2021

Uh oh!

JohnTitor commented Feb 17, 2021

Uh oh!

Dylan-DPC-zz commented Feb 17, 2021

Uh oh!

c410-f3r commented Feb 17, 2021

Uh oh!

Uh oh!

Move some tests to more reasonable directories - 4 #81941

Move some tests to more reasonable directories - 4 #81941

Uh oh!

Conversation

c410-f3r commented Feb 9, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Feb 13, 2021

Uh oh!

This comment has been minimized.

c410-f3r commented Feb 14, 2021

Uh oh!

petrochenkov commented Feb 15, 2021

Uh oh!

bors commented Feb 15, 2021

Uh oh!

JohnTitor commented Feb 15, 2021

Uh oh!

petrochenkov commented Feb 15, 2021

Uh oh!

bors commented Feb 15, 2021

Uh oh!

Dylan-DPC-zz commented Feb 17, 2021

Uh oh!

c410-f3r commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c410-f3r commented Feb 17, 2021

Uh oh!

JohnTitor commented Feb 17, 2021

Uh oh!

Dylan-DPC-zz commented Feb 17, 2021

Uh oh!

c410-f3r commented Feb 17, 2021

Uh oh!

Uh oh!

c410-f3r commented Feb 17, 2021 •

edited

Loading